Skip to content

Set Default Audit Log Retention#616

Merged
oglok merged 1 commit into
openshift:mainfrom
adambkaplan:kube-api-audit-retention-default
Mar 7, 2022
Merged

Set Default Audit Log Retention#616
oglok merged 1 commit into
openshift:mainfrom
adambkaplan:kube-api-audit-retention-default

Conversation

@adambkaplan

Copy link
Copy Markdown
Contributor

If an audit log directory is provided, set the default audit log
retention age to 7 days. When --audit-log-maxage is not specified,
kube-apiserver audit logs are retained indefinitely, taking up
signficant space on the host node.

Which issue(s) this PR addresses:

Closes #613

If an audit log directory is provided, set the default audit log
retention age to 7 days. When `--audit-log-maxage` is not specified,
kube-apiserver audit logs are retained indefinitely, taking up
signficant space on the host node.
@openshift-ci openshift-ci Bot requested review from fzdarsky and oglok March 4, 2022 16:57
@openshift-ci

openshift-ci Bot commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

Hi @adambkaplan. Thanks for your PR.

I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 4, 2022
@copejon

copejon commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2022
@oglok

oglok commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oglok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@oglok oglok merged commit 27241be into openshift:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Retain Audit Logs for 7 days

3 participants